[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

[Dave Lee via Phabricator via lldb-commits]

kastiglione created this revision.
kastiglione added reviewers: jingham, aprantl, jasonmolenda.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

When `disassemble --mixed` is run, do not show source for line zero, as intended.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150383

Files:
  lldb/source/Core/Disassembler.cpp


Index: lldb/source/Core/Disassembler.cpp
===================================================================
--- lldb/source/Core/Disassembler.cpp
+++ lldb/source/Core/Disassembler.cpp
@@ -243,7 +243,7 @@
 
   // Skip any line #0 entries - they are implementation details
   if (line.line == 0)
-    return false;
+    return true;
 
   ThreadSP thread_sp = exe_ctx.GetThreadSP();
   if (thread_sp) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150383.521360.patch
Type: text/x-patch
Size: 401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230511/714b9a48/attachment.bin>