[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 9 14:19:41 PDT 2023


bulbazord added inline comments.


================
Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24
     SBDebugger::Initialize();
     m_dbg = SBDebugger::Create(/*source_init_files=*/false);
   }
----------------
jingham wrote:
> It isn't clear to me how the changes in this file fit in with your overall goal?
I'm removing the `SBCommandInterpreter` member of this class because in order to construct an object of this class, `SBCommandInterpreter` would need to have an empty default constructor (which we do not have currently). I didn't want to add a constructor for SBCommandInterpreter just to avoid changing the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150157/new/

https://reviews.llvm.org/D150157



More information about the lldb-commits mailing list