[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 28 11:13:57 PDT 2023


mib added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:420
+  error = ::LSOpenURLsWithRole(
+      /*inURLs=*/cf_array.get(), /*inRole=*/kLSRolesAll,
+      /*inAEParam=*/&file_and_line_desc,
----------------
I guess we could narrow down the `inRole` argument: https://developer.apple.com/documentation/coreservices/lsrolesmask/klsroleseditor?language=objc`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149472/new/

https://reviews.llvm.org/D149472



More information about the lldb-commits mailing list