[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D146058#4224001 <https://reviews.llvm.org/D146058#4224001>, @sgraenitz wrote:

> In D146058#4223575 <https://reviews.llvm.org/D146058#4223575>, @labath wrote:
>
>> What kind of setup is necessary to make that work? If it's not too complicated, I think we could make something work.
>
> Thanks, that'd be awesome!
>
> The last official release is from 2020, so for the time being it seems best to build and install from TOT once -- @theraven please correct me if I am wrong:
>
>   > git clone https://github.com/gnustep/libobjc2
>   > cd libobjc2
>   > git submodule init && git submodule update
>   > CC=clang-15 CXX=clang++-15 cmake -Bbuild -GNinja -DTESTS=On .
>   > cd build
>   > ninja
>   ...
>   > ctest
>   ...
>   100% tests passed, 0 tests failed out of 198
>   > ninja install
>   ...
>   -- Installing: /usr/local/lib/libobjc.so.4.6
>   -- Installing: /usr/local/lib/libobjc.so
>   ...
>
> Then apply this patch and re-run CMake. The new test should popup and pass:

I'm sorry for the delay. Building a package from source is slightly more that what I have time for right now. As you may have noticed, I don't have much time for LLDB work right now, and I'm trying to keep the buildbot a vanilla debian install so it's easy to reproduce its setup (both for myself and other developers).

> How can I change this to support the well-behaved bot? Add `-DLLDB_TEST_OBJC_GNUSTEP=Off`? Or should it be off by default and enabled on demand?

That's not entirely what I was referring to. What I fear is the following situation. A random developer makes a random patch that happens to break gnustep support. That developer cannot debug that issue locally (cannot or doesn't know how to build gnustep from source), so someone has to help him figure out the problem. I don't want to be the person doing that. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058