[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added a reviewer: jingham.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This adds some tests for removing lldb commands, user command and aliases. I've done in the SB API side for comleteness of this features. Besides that, I found a bug in the creation of the DummyCommand used in the test file: they were being allocated in the stack but they should have been allocated in the heap because CommandPluginInterfaceImplementation ends up owning the pointer passed to it, which is internally managed by a shared_ptr.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149379

Files:
  lldb/include/lldb/API/SBCommandInterpreter.h
  lldb/source/API/SBCommandInterpreter.cpp
  lldb/unittests/API/SBCommandInterpreterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149379.517708.patch
Type: text/x-patch
Size: 8800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230427/d1950d1a/attachment.bin>