[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

In D148752#4283899 <https://reviews.llvm.org/D148752#4283899>, @manojgupta wrote:

> I am building on ChromeOS. We only have headers from linux kernel 4.14 available in our build system (The actual running kernel could be a higher version).
> But given these functions/struct definitions (sve::<foo>) are already available and used, why are they not used consistently?
>
> e.g. https://source.chromium.org/chromium/external/github.com/llvm/llvm-project/+/main:lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp;l=99
> already uses sve::vl_valid and there are uses of sve::user_sve_header as well.

sve:: namespace introduced SVE helpers from linux headers into LLDB just to avoid the problems such as the one you encountered. The only issue here is that we actually dont want to keep multiple copies of sve headers for ever and want to make sure that every use-case can pull SVE headers from linux headers and we can eventually remove the LLDB copy of these headers.

I am approving this patch but be aware that we may consider removing all sve:: helpers from LLDB in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148752/new/

https://reviews.llvm.org/D148752