[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 25 11:26:35 PDT 2023


mib added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1219-1220
 
+        stream = lldb.SBStream()
+        event.GetDescription(stream)
         test.fail("received event '%s' from unexpected broadcaster '%s'." %
----------------
bulbazord wrote:
> I'm not sure why you added this part? Is there something not great about calling `SBEvent::GetDescription` directly?
This is actually a fix of the original implementation (`SBEvent::GetDescription` requires a `SBStream` argument but when added this helper function, we never took this code path, so we never hit that error).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149175/new/

https://reviews.llvm.org/D149175



More information about the lldb-commits mailing list