[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

[Nick Desaulniers via Phabricator via lldb-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19
 
+#include <llvm/ADT/StringViewExtras.h>
+
----------------
MaskRay wrote:
> chapuni wrote:
> > Odd layering...
> Good catch. LLVMDemangle cannot depend on other LLVM libraries.
If these are inline function definitions, then there is no linkage between the libraries?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148384/new/

https://reviews.llvm.org/D148384