[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

[Nick Desaulniers via Phabricator via lldb-commits]

nickdesaulniers added a comment.

In D148384#4270505 <https://reviews.llvm.org/D148384#4270505>, @dhoekwater wrote:

> It looks like this breaks the build: https://lab.llvm.org/buildbot#builders/119/builds/12865 https://lab.llvm.org/buildbot#builders/123/builds/18388 https://lab.llvm.org/buildbot#builders/60/builds/11628

Ah, I see what happened.  Those 3 builds had my follow up commit https://reviews.llvm.org/D148392, BUT the initial broken builds stopped producing diagnostics after the initial set of diagnostics that I fixed; kind of like how clang stops emitting diagnostics after the first 20. You can fix the 20, but there might be more to fix. That's what happened here.  Specifically, I see 3 new diagnostics that weren't addressed in https://reviews.llvm.org/D148392:

1. llvm\lib\Demangle\MicrosoftDemangle.cpp(809)
2. llvm\include\llvm/Demangle/ItaniumDemangle.h(2334)
3. llvm\include\llvm/Demangle/ItaniumDemangle.h(2335)

I'll reopen this with https://reviews.llvm.org/D148392 squashed, plus the above three issues fixed, then get a colleague with a windows machine to help verify.

In D148384#4270554 <https://reviews.llvm.org/D148384#4270554>, @MaskRay wrote:

> I am unsure about the Windows issue and find it difficult to repair...   I'm testing a revert commit to not leave issues to the weekend.

That was the right thing to do, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148384/new/

https://reviews.llvm.org/D148384