[Lldb-commits] [lldb] 9fdf82d - [LLDB] Fix broken Windows unittests build

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Sun Apr 16 20:37:49 PDT 2023


Author: Muhammad Omair Javaid
Date: 2023-04-17T08:31:43+05:00
New Revision: 9fdf82dc32dc38e0b92dab3215a83d8f3c2f9bbf

URL: https://github.com/llvm/llvm-project/commit/9fdf82dc32dc38e0b92dab3215a83d8f3c2f9bbf
DIFF: https://github.com/llvm/llvm-project/commit/9fdf82dc32dc38e0b92dab3215a83d8f3c2f9bbf.diff

LOG: [LLDB] Fix broken Windows unittests build

LLDB Windows tests were broken because SymbolFilePDBTests.cpp failed
to compile after 6cdfa295743729178ff6f15a8dcd36f8f7d27c2c.

This patch fixes the SymbolFilePDBTests.cpp. (Tested on Surface X Pro)

https://lab.llvm.org/buildbot/#/builders/219

Differential Revision: https://reviews.llvm.org/D147436

Added: 
    

Modified: 
    lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
index 2c49b34b34fe3..bd69d246072ca 100644
--- a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
+++ b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
@@ -456,7 +456,8 @@ TEST_F(SymbolFilePDBTests, TestClassInNamespace) {
   symfile->ParseDeclsForContext(CompilerDeclContext(
       clang_ast_ctx, static_cast<clang::DeclContext *>(tu)));
 
-  auto ns_namespace = symfile->FindNamespace(ConstString("NS"), CompilerDeclContext());
+  auto ns_namespace =
+      symfile->FindNamespace(ConstString("NS"), CompilerDeclContext(), true);
   EXPECT_TRUE(ns_namespace.IsValid());
 
   symfile->FindTypes(ConstString("NSClass"), ns_namespace, 0, searched_files,


        


More information about the lldb-commits mailing list