[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/test/API/macosx/symbols/TestObjectFileJSON.py:82
+        }
+        self.emitJSON(data, json_object_file)
+
----------------
The test was (95%!) flaky because the two generated files had the same timestamp (and so lldb considered them identical and did not reload). I fixed that by adding a sleep, but your intention was not to test file reloading then it would be better to just use different filenames.

(There could also be a bug somewhere, because I was under the impression that we should treat files with different UUIDs as distinct even if they happen to have the same timestamp.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148062/new/

https://reviews.llvm.org/D148062