[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

Thu Apr 13 05:17:15 PDT 2023

sgraenitz added a comment.

Addressed feedback and added handling for `R_ARM_REL32`. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being.

================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640

+static void ApplyELF32ABS32Relocation(Symtab *symtab, ELFRelocation &rel,
+                                      DataExtractor &debug_data,
----------------
peter.smith wrote:
> IIUC the  largest difference between this and ApplyELF64ABS32Relocation is the use of REL rather than RELA relocations. Perhaps worth naming it as `ApplyELF32ABS32RelRelocation` 
Thanks, very good point. Done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147642/new/

https://reviews.llvm.org/D147642