[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 12 18:21:34 PDT 2023


mib added inline comments.


================
Comment at: lldb/examples/python/symbolication.py:399
+                            'name' : section.name,
+                            'address': 0,
+                            'size': section.end_addr - section.start_addr
----------------
Since this field is optional in the ObjectFileJSON, I think it should be included here. We should just initialize it to `0` in lldb if the user didn't provide it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148172/new/

https://reviews.llvm.org/D148172



More information about the lldb-commits mailing list