[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 512610.
jasonmolenda added a comment.

Update the patch to incorporate David's first feedback.  I know this is a bit of a tricky patch to review because it is 95% comments/documentation/renaming of variables, followed by the one key change of removing `core >= ArchSpec::eCore_arm_generic && core <= ArchSpec::eCore_arm_aarch64)` which means ARM systems won't follow this MIPS false-watchpoint-hit behavior any more, for a watchpoint trap address outside the address range being watched (but DOES access the watched range on ARM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147816/new/

https://reviews.llvm.org/D147816

Files:
  lldb/docs/lldb-gdb-remote.txt
  lldb/include/lldb/Target/StopInfo.h
  lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Target/StopInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147816.512610.patch
Type: text/x-patch
Size: 14220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230411/f0c85e9a/attachment.bin>