[Lldb-commits] [PATCH] D148050: [lldb] Change formatter helper function parameter list to remove ConstString

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 11 14:10:04 PDT 2023


bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

All of these functions take a ConstString for the type_name,
but this isn't really needed for two reasons:
1.) This parameter is always constructed from a static c-string

  constant.

2.) They are passed along to to `AddTypeSummary` as a StringRef anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148050

Files:
  lldb/include/lldb/DataFormatters/FormattersHelpers.h
  lldb/source/DataFormatters/FormatManager.cpp
  lldb/source/DataFormatters/FormattersHelpers.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148050.512578.patch
Type: text/x-patch
Size: 96069 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230411/4ea5349b/attachment-0001.bin>


More information about the lldb-commits mailing list