[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

Fri Apr 7 13:59:07 PDT 2023

rupprecht added inline comments.

================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:3158
+#if defined(__linux__)
+  (void)prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY, 0, 0, 0);
+#endif
----------------
https://manpages.debian.org/bullseye/manpages-dev/prctl.2.en.html#PR_SET_PTRACER

It would be nice if we could avoid `PR_SET_PTRACER_ANY` and set the pid directly. (Maybe you will need an additional flag, along with --comm-file and --launch-target?). Using `PR_SET_PTRACER_ANY` effectively circumvents the system's ptrace policy, IIUC.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147805/new/

https://reviews.llvm.org/D147805