[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added inline comments.


================
Comment at: lldb/include/lldb/Utility/FileSpec.h:330
   /// filename has no extension, ConstString(nullptr) is returned. The dot
-  /// ('.') character is not returned as part of the extension
+  /// ('.') character is the first character in the returned string.
   ///
----------------
JDevlieghere wrote:
> mib wrote:
> > This sounds like a pretty intrusive change ... was the comment wrong or did change the implementation on another commit ?
> I changed the behavior in ad8d48f9036f9 but forgot to update the comment.
LGTM then :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147801/new/

https://reviews.llvm.org/D147801