[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 7 12:27:02 PDT 2023
JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Utility/FileSpec.h:330
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the first character in the returned string.
///
----------------
mib wrote:
> This sounds like a pretty intrusive change ... was the comment wrong or did change the implementation on another commit ?
I changed the behavior in ad8d48f9036f9 but forgot to update the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147801/new/
https://reviews.llvm.org/D147801
More information about the lldb-commits
mailing list