[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Target/StackFrameList.cpp:823
+    SelectMostRelevantFrame();
+    m_selected_frame_set = true;
+  }  
----------------
jingham wrote:
> JDevlieghere wrote:
> > IIUC `SetSelectedFrame` always sets `m_selected_frame_set` to `true`, so is this redundant?
>  Sure, but if you do that you have to change SelectMostRelevantFrame to select the 0th frame if there's no relevant frame.  At present it leaves it unselected.  Doing the selection always in SMRF  is clearer, though, so it would be a good change.
Nvm, I confused `SelectMostRelevantFrame` with `SetSelectedFrame`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147753/new/

https://reviews.llvm.org/D147753