[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Agreed.

The tangled web of switch statements makes my head spin so if you ever feel like tackling that please do :)



================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2704
+        default:
+          assert(false && "unexpected relocation type");
+          break;
----------------
Should this report error also? Given that you want it to not crash.

Though it did that already, you must have had reason to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147627/new/

https://reviews.llvm.org/D147627