[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

Tue Apr 4 08:42:49 PDT 2023

kuilpd added a comment.

In D146965#4240075 <https://reviews.llvm.org/D146965#4240075>, @DavidSpickett wrote:

> Two things come to mind:
>
> - Core files (though it is embedded so is that even a thing?)

It is completely bare metal, but the address space is only 16-bit, so would the entire 64 KB of memory count as a core dump?

> - Mocking an msp430 remote, as we do for example in Target XML tests.

mspdebug (the tool that implements gdb server for MSP430) doesn't have a lot of features, doesn't support memory region info or even target.xml with register information, so it all comes down to fallback information in LLDB.
I can make a test that checks if fallback information even exists and registers have correct data and size, for example.
What else would you recommend to test for?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146965/new/

https://reviews.llvm.org/D146965