[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053
+      // appears once, so we don't have to handle that here.
+      if (attr_name == "name") {
+        LLDB_LOGF(log,
----------------
Do you think that using a `StringSwitch` could improve readability? 


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4066
+                "ProcessGDBRemote::ParseFlags Invalid start %d in field node, "
+                "cannot be > %d",
+                parsed_start, max_start_bit);
----------------
jasonmolenda wrote:
> All of the bit positions are `unsigned`, `%u`'s to be proper (and further printf specifiers below.  not that it will matter, of course.)
Alternatively you can use `LLDB_LOG` which uses LLVM's [[ https://llvm.org/doxygen/FormatVariadic_8h_source.html | formatv ]] under the hood and not have to bother about format specifiers. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145574/new/

https://reviews.llvm.org/D145574