[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

The big assumption here is that the GDB process lasts longer than the higher level debug session does. I am keeping a map of register name to unique pointer in the GDB process, then giving out raw pointers to the higher level commands. The higher level is destroyed first, then the GDB process which frees all the unique pointers. This means that the register info struct remains trivial, it wouldn't be if we stored the registerfields type directly in it.

The obvious way to try to break that is to cut the connection to the remote but even so, I think the GDB process on lldb's side still exists (albeit erroring for everything).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145574/new/

https://reviews.llvm.org/D145574