[Lldb-commits] [PATCH] D146293: [lldb][gnustep][PDB] Recognize ObjC classes and start definition only once the complete type is requested

Fri Mar 17 06:13:03 PDT 2023

sgraenitz added a comment.

In order to run the test yourself locally, you also need to apply D146058 <https://reviews.llvm.org/D146058>, D146154 <https://reviews.llvm.org/D146154> and D146221 <https://reviews.llvm.org/D146221> first (right now they are still in review).

================
Comment at: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:414
+      lang = eLanguageTypeObjC;
+
     // Check if such an UDT already exists in the current context.
----------------
I am not an ObjC expert, but from those who are I know that in practice this should holds for all common scenarios. So far it works reliably.

Right now I'd like to avoid patching the PDB contents from the compiler side. Would be great to see how far we get without. If there's a better way to do the same based on current PDB info, please let me know.

================
Comment at: lldb/test/Shell/Expr/objc-gnustep-print-pdb.m:1
+// REQUIRES: objc-gnustep && system-windows
+//
----------------
This test is supposed to demonstrate what works with this patch. I will remove it once we match the features in the Linux/DWARF baseline proposed in: D146154 test objc-gnustep-print.m

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146293/new/

https://reviews.llvm.org/D146293