[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/test/Shell/helper/toolchain.py:46
+    if config.objc_gnustep_dir:
+        build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir))
 
----------------
sgraenitz wrote:
> bulbazord wrote:
> > Why does {0} need quotes around it but the args above it don't?
> Good catch! That's due to spaces in Windows paths...
In that case, do we also need to add quotes around the other paths? Seems like we're assuming that on windows those directories cannot have spaces in them. (Not suggesting you need to do that here and now, just wondering for the future)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058