[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added inline comments.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp:253
+}
+
 ObjCLanguageRuntime::ObjCISA
----------------
This was always declared in the header, but never implemented. Instead, AppleObjCRuntime had its own implementation -- I could make a follow-up patch to reuse it there as well:
https://github.com/llvm/llvm-project/blob/release/16.x/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp#L609-L622


================
Comment at: lldb/test/Shell/Expr/objc-gnustep-print.m:62
 // SELF:     refcount
 // SELF:   }
 // SELF: }
----------------
This is missing the newly added members. I will fix it in the course of this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146154/new/

https://reviews.llvm.org/D146154