[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

I tested this on 32 bit Arm Linux and after a few bodges (see comment), the test itself works fine. I see the CI for the library cross compiles for this, so it makes sense.



================
Comment at: lldb/test/Shell/helper/build.py:256
+            self.objc_gnustep_inc = os.path.join(args.objc_gnustep_dir, 'include')
+            self.objc_gnustep_lib = os.path.join(args.objc_gnustep_dir, 'lib')
 
----------------
These need to be defined always, and set to either `None` or `""`. Otherwise what happens is if args.objc_gnustep is not set, these variables don't exist and later it will try to read objc_gnustep_inc and fail.

Or you could `hasattr` later but I think empty defaults is cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058