[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

[Alexander Richardson via Phabricator via lldb-commits]

arichardson added a comment.

Minor suggestions, feel free to ignore.



================
Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14
 FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); }
 
 void FreeBSDSignals::Reset() {
----------------
I wonder if it would make sense to do something like the following to ensure we use the same numbers as defined in FreeBSD (compile-time checks when building on a FreeBSD host). The it would be possible to use 
`FREEBSD_ILL_ILLOPC` instead of `1 /*ILL_ILLOPC*/` below


================
Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:57
+  AddSignal(32,   "SIGTHR",      false,   false, false, "thread interrupt");
+  AddSignal(33,   "SIGLIBRT",    false,   false, false, "reserved by real-time library");
+  AddSignal(65,   "SIGRTMIN",    false,   false, false, "real time signal 0");
----------------
Not sure if it's worth adding here, but CheriBSD (a fork of FreeBSD with support for CHERI) uses 34 for "SIGPROT": https://github.com/CTSRD-CHERI/cheribsd/blob/8993e1c3bba52a2610f863d206b319904c22e121/sys/sys/signal.h#L134


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146044/new/

https://reviews.llvm.org/D146044