[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

Tue Mar 14 11:17:51 PDT 2023

sgraenitz added a comment.

In D146058#4193795 <https://reviews.llvm.org/D146058#4193795>, @stella.stamenova wrote:

> The one I was referring to is https://lab.llvm.org/buildbot/#/builders/219.

Ok, thanks for the update. Then we are lacking a Windows x86 build bot for LLDB now!

> Also, the one that was removed was not x86 either, it was x64.

Yes, the naming can be confusing. I think the x86 we talked about mainly means 64-bit (often called x64 on Windows) and includes the 32-bit legacy. Like the `X86` target backend in LLVM.

================
Comment at: lldb/test/Shell/helper/build.py:254
+        if args.objc_gnustep:
+            assert args.objc_gnustep_dir, "GNUstep libobjc2 runtime for Linux and Windows"
+            self.objc_gnustep_inc = os.path.join(args.objc_gnustep_dir, 'include')
----------------
bulbazord wrote:
> The assertion message here is not tremendously helpful. Maybe something like "--objc-gnustep specified without path to libobjc2. Use --objc-gnustep-dir to specify said path."
None of the other `assert`s have messages at all, but ok :)

================
Comment at: lldb/test/Shell/helper/toolchain.py:46
+    if config.objc_gnustep_dir:
+        build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir))

----------------
bulbazord wrote:
> Why does {0} need quotes around it but the args above it don't?
Good catch! That's due to spaces in Windows paths...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058