[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with Pavel's comments.



================
Comment at: lldb/unittests/Signals/UnixSignalsTest.cpp:132-134
+  EXPECT_EQ(expected, signals.GetSignalAsString(16, 3));
+  EXPECT_EQ(expected, signals.GetSignalAsString(16, 3, 0xcafef00d));
+  EXPECT_EQ(expected, signals.GetSignalAsString(16, 3, 0xcafef00d, 0x1234));
----------------
Nit: If these all need to pass maybe make these `ASSERT_EQ` so you don't get an "expected" failure below. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146044/new/

https://reviews.llvm.org/D146044