[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/test/Shell/helper/build.py:254
+        if args.objc_gnustep:
+            assert args.objc_gnustep_dir, "GNUstep libobjc2 runtime for Linux and Windows"
+            self.objc_gnustep_inc = os.path.join(args.objc_gnustep_dir, 'include')
----------------
The assertion message here is not tremendously helpful. Maybe something like "--objc-gnustep specified without path to libobjc2. Use --objc-gnustep-dir to specify said path."


================
Comment at: lldb/test/Shell/helper/toolchain.py:46
+    if config.objc_gnustep_dir:
+        build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir))
 
----------------
Why does {0} need quotes around it but the args above it don't?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058