[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

Jun Zhang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 14 08:10:31 PDT 2023


junaire added a comment.

I'm not certain if it's bad to say 'sorry', IMHO it's fine?

Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146041/new/

https://reviews.llvm.org/D146041



More information about the lldb-commits mailing list