[Lldb-commits] [lldb] 93a4553 - [lldb] Remove MIPS Linux UnixSignals

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 13 17:17:56 PDT 2023


Author: Alex Langford
Date: 2023-03-13T17:17:47-07:00
New Revision: 93a455375c0fa1dd014a3b4571b22e307d15bbf7

URL: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7
DIFF: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7.diff

LOG: [lldb] Remove MIPS Linux UnixSignals

MIPS Linux support was removed in ce03a862372a6f36d2fcf80dc80052aa155fcae8

Added: 
    

Modified: 
    lldb/source/Plugins/Process/Utility/CMakeLists.txt
    lldb/source/Target/UnixSignals.cpp

Removed: 
    lldb/source/Plugins/Process/Utility/MipsLinuxSignals.cpp
    lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h


################################################################################
diff  --git a/lldb/source/Plugins/Process/Utility/CMakeLists.txt b/lldb/source/Plugins/Process/Utility/CMakeLists.txt
index 912d763ab663..edf4e851b653 100644
--- a/lldb/source/Plugins/Process/Utility/CMakeLists.txt
+++ b/lldb/source/Plugins/Process/Utility/CMakeLists.txt
@@ -8,7 +8,6 @@ add_lldb_library(lldbPluginProcessUtility
   LinuxProcMaps.cpp
   LinuxSignals.cpp
   MemoryTagManagerAArch64MTE.cpp
-  MipsLinuxSignals.cpp
   NativeProcessSoftwareSingleStep.cpp
   NativeRegisterContextDBReg_arm64.cpp
   NativeRegisterContextDBReg_x86.cpp

diff  --git a/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.cpp b/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.cpp
deleted file mode 100644
index fb51c56953f8..000000000000
--- a/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.cpp
+++ /dev/null
@@ -1,85 +0,0 @@
-//===-- MipsLinuxSignals.cpp ----------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "MipsLinuxSignals.h"
-
-using namespace lldb_private;
-
-MipsLinuxSignals::MipsLinuxSignals() : UnixSignals() { Reset(); }
-
-void MipsLinuxSignals::Reset() {
-  m_signals.clear();
-  // clang-format off
-  //        SIGNO   NAME            SUPPRESS  STOP    NOTIFY  DESCRIPTION
-  //        ======  ==============  ========  ======  ======  ===================================================
-  AddSignal(1, "SIGHUP",            false,    true,   true,   "hangup");
-  AddSignal(2, "SIGINT",            true,     true,   true,   "interrupt");
-  AddSignal(3, "SIGQUIT",           false,    true,   true,   "quit");
-  AddSignal(4, "SIGILL",            false,    true,   true,   "illegal instruction");
-  AddSignal(5, "SIGTRAP",           true,     true,   true,   "trace trap (not reset when caught)");
-  AddSignal(6, "SIGABRT",           false,    true,   true,   "abort()/IOT trap", "SIGIOT");
-  AddSignal(7, "SIGEMT",            false,    true,   true,   "terminate process with core dump");
-  AddSignal(8, "SIGFPE",            false,    true,   true,   "floating point exception");
-  AddSignal(9, "SIGKILL",           false,    true,   true,   "kill");
-  AddSignal(10, "SIGBUS",           false,    true,   true,   "bus error");
-  AddSignal(11, "SIGSEGV",          false,    true,   true,   "segmentation violation");
-  AddSignal(12, "SIGSYS",           false,    true,   true,   "invalid system call");
-  AddSignal(13, "SIGPIPE",          false,    true,   true,   "write to pipe with reading end closed");
-  AddSignal(14, "SIGALRM",          false,    false,  false,  "alarm");
-  AddSignal(15, "SIGTERM",          false,    true,   true,   "termination requested");
-  AddSignal(16, "SIGUSR1",          false,    true,   true,   "user defined signal 1");
-  AddSignal(17, "SIGUSR2",          false,    true,   true,   "user defined signal 2");
-  AddSignal(18, "SIGCHLD",          false,    false,  true,   "child status has changed", "SIGCLD");
-  AddSignal(19, "SIGPWR",           false,    true,   true,   "power failure");
-  AddSignal(20, "SIGWINCH",         false,    true,   true,   "window size changes");
-  AddSignal(21, "SIGURG",           false,    true,   true,   "urgent data on socket");
-  AddSignal(22, "SIGIO",            false,    true,   true,   "input/output ready/Pollable event", "SIGPOLL");
-  AddSignal(23, "SIGSTOP",          true,     true,   true,   "process stop");
-  AddSignal(24, "SIGTSTP",          false,    true,   true,   "tty stop");
-  AddSignal(25, "SIGCONT",          false,    false,  true,   "process continue");
-  AddSignal(26, "SIGTTIN",          false,    true,   true,   "background tty read");
-  AddSignal(27, "SIGTTOU",          false,    true,   true,   "background tty write");
-  AddSignal(28, "SIGVTALRM",        false,    true,   true,   "virtual time alarm");
-  AddSignal(29, "SIGPROF",          false,    false,  false,  "profiling time alarm");
-  AddSignal(30, "SIGXCPU",          false,    true,   true,   "CPU resource exceeded");
-  AddSignal(31, "SIGXFSZ",          false,    true,   true,   "file size limit exceeded");
-  AddSignal(32, "SIG32",            false,    false,  false,  "threading library internal signal 1");
-  AddSignal(33, "SIG33",            false,    false,  false,  "threading library internal signal 2");
-  AddSignal(34, "SIGRTMIN",         false,    false,  false,  "real time signal 0");
-  AddSignal(35, "SIGRTMIN+1",       false,    false,  false,  "real time signal 1");
-  AddSignal(36, "SIGRTMIN+2",       false,    false,  false,  "real time signal 2");
-  AddSignal(37, "SIGRTMIN+3",       false,    false,  false,  "real time signal 3");
-  AddSignal(38, "SIGRTMIN+4",       false,    false,  false,  "real time signal 4");
-  AddSignal(39, "SIGRTMIN+5",       false,    false,  false,  "real time signal 5");
-  AddSignal(40, "SIGRTMIN+6",       false,    false,  false,  "real time signal 6");
-  AddSignal(41, "SIGRTMIN+7",       false,    false,  false,  "real time signal 7");
-  AddSignal(42, "SIGRTMIN+8",       false,    false,  false,  "real time signal 8");
-  AddSignal(43, "SIGRTMIN+9",       false,    false,  false,  "real time signal 9");
-  AddSignal(44, "SIGRTMIN+10",      false,    false,  false,  "real time signal 10");
-  AddSignal(45, "SIGRTMIN+11",      false,    false,  false,  "real time signal 11");
-  AddSignal(46, "SIGRTMIN+12",      false,    false,  false,  "real time signal 12");
-  AddSignal(47, "SIGRTMIN+13",      false,    false,  false,  "real time signal 13");
-  AddSignal(48, "SIGRTMIN+14",      false,    false,  false,  "real time signal 14");
-  AddSignal(49, "SIGRTMIN+15",      false,    false,  false,  "real time signal 15");
-  AddSignal(50, "SIGRTMAX-14",      false,    false,  false,  "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill -l" output
-  AddSignal(51, "SIGRTMAX-13",      false,    false,  false,  "real time signal 17");
-  AddSignal(52, "SIGRTMAX-12",      false,    false,  false,  "real time signal 18");
-  AddSignal(53, "SIGRTMAX-11",      false,    false,  false,  "real time signal 19");
-  AddSignal(54, "SIGRTMAX-10",      false,    false,  false,  "real time signal 20");
-  AddSignal(55, "SIGRTMAX-9",       false,    false,  false,  "real time signal 21");
-  AddSignal(56, "SIGRTMAX-8",       false,    false,  false,  "real time signal 22");
-  AddSignal(57, "SIGRTMAX-7",       false,    false,  false,  "real time signal 23");
-  AddSignal(58, "SIGRTMAX-6",       false,    false,  false,  "real time signal 24");
-  AddSignal(59, "SIGRTMAX-5",       false,    false,  false,  "real time signal 25");
-  AddSignal(60, "SIGRTMAX-4",       false,    false,  false,  "real time signal 26");
-  AddSignal(61, "SIGRTMAX-3",       false,    false,  false,  "real time signal 27");
-  AddSignal(62, "SIGRTMAX-2",       false,    false,  false,  "real time signal 28");
-  AddSignal(63, "SIGRTMAX-1",       false,    false,  false,  "real time signal 29");
-  AddSignal(64, "SIGRTMAX",         false,    false,  false,  "real time signal 30");
-  // clang-format on
-}

diff  --git a/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h b/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h
deleted file mode 100644
index 6b78fc72a91c..000000000000
--- a/lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h
+++ /dev/null
@@ -1,28 +0,0 @@
-//===-- MipsLinuxSignals.h ------------------------------------------*- C++
-//-*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H
-#define LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H
-
-#include "lldb/Target/UnixSignals.h"
-
-namespace lldb_private {
-
-/// Linux specific set of Unix signals.
-class MipsLinuxSignals : public UnixSignals {
-public:
-  MipsLinuxSignals();
-
-private:
-  void Reset() override;
-};
-
-} // namespace lldb_private
-
-#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H

diff  --git a/lldb/source/Target/UnixSignals.cpp b/lldb/source/Target/UnixSignals.cpp
index 858b1691f318..02354be44cfe 100644
--- a/lldb/source/Target/UnixSignals.cpp
+++ b/lldb/source/Target/UnixSignals.cpp
@@ -9,7 +9,6 @@
 #include "lldb/Target/UnixSignals.h"
 #include "Plugins/Process/Utility/FreeBSDSignals.h"
 #include "Plugins/Process/Utility/LinuxSignals.h"
-#include "Plugins/Process/Utility/MipsLinuxSignals.h"
 #include "Plugins/Process/Utility/NetBSDSignals.h"
 #include "lldb/Host/HostInfo.h"
 #include "lldb/Utility/ArchSpec.h"
@@ -33,17 +32,8 @@ UnixSignals::Signal::Signal(const char *name, bool default_suppress,
 lldb::UnixSignalsSP UnixSignals::Create(const ArchSpec &arch) {
   const auto &triple = arch.GetTriple();
   switch (triple.getOS()) {
-  case llvm::Triple::Linux: {
-    switch (triple.getArch()) {
-    case llvm::Triple::mips:
-    case llvm::Triple::mipsel:
-    case llvm::Triple::mips64:
-    case llvm::Triple::mips64el:
-      return std::make_shared<MipsLinuxSignals>();
-    default:
-      return std::make_shared<LinuxSignals>();
-    }
-  }
+  case llvm::Triple::Linux:
+    return std::make_shared<LinuxSignals>();
   case llvm::Triple::FreeBSD:
   case llvm::Triple::OpenBSD:
     return std::make_shared<FreeBSDSignals>();


        


More information about the lldb-commits mailing list