[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

Mon Mar 13 15:38:47 PDT 2023

bulbazord added inline comments.

================
Comment at: lldb/source/Target/Memory.cpp:245-246
+    if (m_invalid_ranges.FindEntryThatContains(cache_line_base_addr)) {
+      error.SetErrorStringWithFormat("memory read failed for 0x%" PRIx64,
+                                     cache_line_base_addr);
+      return dst_len - bytes_left;
----------------
clayborg wrote:
> Is this an error here? We already got something from the first read and we are just returning partial data, do we need an error? If we fail the first read, then this is an error. 
If the second cache line you read is in an invalid range, maybe the user would want some feedback about why it was a partial read. It's a detectable condition. Maybe we shouldn't set an error string though, idk.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145624/new/

https://reviews.llvm.org/D145624