[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Vlad Serebrennikov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 13 08:45:40 PDT 2023


Endill added a comment.

In D140996#4189452 <https://reviews.llvm.org/D140996#4189452>, @bolshakov-a wrote:

> Sorry! It's my first time using Phabricator. Maybe, the problem occurs because I've solved the issue with Arcanist just by means of copy-pasting patches into "Update Diff" Web GUI form.

There's nothing wrong with copy-pasting into web GUI form. You just have to export the patch with the right options, e.g. `git diff HEAD~1 -U999999 > mypatch.patch` (more on this here <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface>).

> Maybe, I should reopen the PR?

You can simply update the review with properly exported patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140996/new/

https://reviews.llvm.org/D140996



More information about the lldb-commits mailing list