[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

This looks good to me.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4066
+                "ProcessGDBRemote::ParseFlags Invalid start %d in field node, "
+                "cannot be > %d",
+                parsed_start, max_start_bit);
----------------
All of the bit positions are `unsigned`, `%u`'s to be proper (and further printf specifiers below.  not that it will matter, of course.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145574/new/

https://reviews.llvm.org/D145574