[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 8 07:54:05 PST 2023


DavidSpickett updated this revision to Diff 503376.
DavidSpickett added a comment.

Use StringRef instead of std::string.

Though an empty StringRef is morally equivalent
to optional, I've stuck with optional to keep the code
looking consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145574/new/

https://reviews.llvm.org/D145574

Files:
  lldb/include/lldb/Target/DynamicRegisterInfo.h
  lldb/include/lldb/lldb-private-types.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  lldb/source/Target/DynamicRegisterInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145574.503376.patch
Type: text/x-patch
Size: 17316 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230308/9fe8e5a3/attachment.bin>


More information about the lldb-commits mailing list