[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/include/lldb/API/SBDebugger.h:203
+  void CancelInterruptRequest();
+  bool InterruptRequested();
 
----------------
bulbazord wrote:
> Could this be marked `const` if the mutex was marked `mutable`?
We don't tend to mark things in the public API as const because it does nothing when you have a pointer, unique pointer or shared pointer as the only member variable. I guess it would stop you from clearing the pointer, but the "const" does nothing to stop the mutation of the underlying object, and it would be weird to add "const" to all methods just to stop each method from modifying the contents of the member variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145136/new/

https://reviews.llvm.org/D145136