[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

Small nits



================
Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:251-253
+  /// Interrupts the command currently executing in the RunCommandInterpreter
+  /// thread.
+  bool InterruptCommand();
----------------
Some info on the return value would be useful here.


================
Comment at: lldb/include/lldb/API/SBDebugger.h:203
+  void CancelInterruptRequest();
+  bool InterruptRequested();
 
----------------
Could this be marked `const` if the mutex was marked `mutable`?


================
Comment at: lldb/include/lldb/Core/Debugger.h:400-401
+  ///
+  /// \param[in] message
+  ///   The new value of the InterruptRequested flag.
+  ///
----------------
This method takes no argument `message`.


================
Comment at: lldb/include/lldb/Core/Debugger.h:397-398
+  /// cooperative interruption.  If this is non-zero, InterruptRequested will
+  /// return true.  Interruptible operations are expected to query this
+  /// flag periodically, and interrupt what they were doing if it is true.
+  ///
----------------
clayborg wrote:
> 
+1. Also you mention the use of "flag" here but talked about counter before which is inconsistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145136/new/

https://reviews.llvm.org/D145136