[Lldb-commits] [lldb] 896a346 - Revert "[lldb/Plugin] Add breakpoint setting support to ScriptedProcesses."
Med Ismail Bennani via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 6 13:18:16 PST 2023
Author: Med Ismail Bennani
Date: 2023-03-06T13:17:45-08:00
New Revision: 896a3469802122a37bba04bfebf2ab302c84cc87
URL: https://github.com/llvm/llvm-project/commit/896a3469802122a37bba04bfebf2ab302c84cc87
DIFF: https://github.com/llvm/llvm-project/commit/896a3469802122a37bba04bfebf2ab302c84cc87.diff
LOG: Revert "[lldb/Plugin] Add breakpoint setting support to ScriptedProcesses."
This reverts commit cfe06f495beb520ab366957d1108bb80c7c92832.
Added:
Modified:
lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
lldb/source/Plugins/Process/scripted/ScriptedProcess.h
Removed:
################################################################################
diff --git a/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp b/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
index 4fd7a46804de..9a670276a8b8 100644
--- a/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
+++ b/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
@@ -282,20 +282,6 @@ size_t ScriptedProcess::DoWriteMemory(lldb::addr_t vm_addr, const void *buf,
return bytes_written;
}
-Status ScriptedProcess::EnableBreakpointSite(BreakpointSite *bp_site) {
- assert(bp_site != nullptr);
-
- if (bp_site->IsEnabled()) {
- return {};
- }
-
- if (bp_site->HardwareRequired()) {
- return Status("Scripted Processes don't support hardware breakpoints");
- }
-
- return EnableSoftwareBreakpoint(bp_site);
-}
-
ArchSpec ScriptedProcess::GetArchitecture() {
return GetTarget().GetArchitecture();
}
diff --git a/lldb/source/Plugins/Process/scripted/ScriptedProcess.h b/lldb/source/Plugins/Process/scripted/ScriptedProcess.h
index 44a514a096d3..368c54b1b461 100644
--- a/lldb/source/Plugins/Process/scripted/ScriptedProcess.h
+++ b/lldb/source/Plugins/Process/scripted/ScriptedProcess.h
@@ -72,8 +72,6 @@ class ScriptedProcess : public Process {
size_t DoWriteMemory(lldb::addr_t vm_addr, const void *buf, size_t size,
Status &error) override;
- Status EnableBreakpointSite(BreakpointSite *bp_site) override;
-
ArchSpec GetArchitecture();
Status
More information about the lldb-commits
mailing list