[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

[Dan Liew via Phabricator via lldb-commits]

delcypher updated this revision to Diff 501356.
delcypher added a comment.

- Add `WatchpointValueKind` enum
- Use `WatchpointValueKind` for new `GetWatchValueKind()` method (previously named `SBWatchpoint::IsWatchVariable`)
- Add `IsWatchingsRead()` method
- Add `IsWatchingWrites()` method
- Remove `m_cached_watch_spec` to avoid breaking ABI.
- In `GetWatchSpec()` use ConstString rather than returning a pointer to owned by the now removed `m_cached_watched_spec`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144937/new/

https://reviews.llvm.org/D144937

Files:
  lldb/bindings/interface/SBWatchpointDocstrings.i
  lldb/docs/python_api_enums.rst
  lldb/include/lldb/API/SBType.h
  lldb/include/lldb/API/SBWatchpoint.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/API/SBWatchpoint.cpp
  lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py
  lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144937.501356.patch
Type: text/x-patch
Size: 11162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230301/3fad8d4c/attachment-0001.bin>