[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectExpression.cpp:149
 
+  case 'C': {
+    // 'C' for "caching", since both 'P' and 'p' for persist are taken. Both 'R'
----------------
aprantl wrote:
> Do we expect people to actually use this flag or to just use an alias that has this turned on? If the latter, maybe we should only provide a long option, since the single-letter name space is precious?
Initially I was going to have only the long option, but I reconsidered because I don't know how frequently persistent results are used by users. In the future, if/when we make the persistent results opt-in (instead of opt-out), will people want to use persistent results sporadically? If so maybe they'd want a short flag to quickly opt-in.

> since the single-letter name space is precious

this is a compelling argument. I'll go with long option only to start. It's easier to add a short option later, than to remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144230/new/

https://reviews.llvm.org/D144230