[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 16 18:48:11 PST 2023


bulbazord added a comment.

In D144238#4133940 <https://reviews.llvm.org/D144238#4133940>, @mib wrote:

> Should we also add a negative integer to the dictionary to make sure this didn't cause a regression ?

Negative integers are not correctly handled currently. I plan on fixing that in a follow-up. See:

  (lldb) script
  Python Interactive Interpreter. To exit, type 'quit()', 'exit()' or Ctrl-D.
  >>> foo = lldb.SBStructuredData()
  >>> foo.SetFromJSON('{"foo": -5}')
  error: <NULL>
  >>> foo.GetValueForKey('foo').GetIntegerValue()
  18446744073709551611


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144238/new/

https://reviews.llvm.org/D144238



More information about the lldb-commits mailing list