[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 4 inline comments as done.
mib added inline comments.


================
Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90
 
+  bool IsScriptedProcess() const;
+
----------------
JDevlieghere wrote:
> Can we not ask this from the ScriptedMetadata?
I think this is fine to ask the `ProcessInfo` for this.

If we got rid of this, instead of calling `IsScriptedProcess`, we would need first to get `ScriptedMetadata` shared pointer and make sure it's not null, then deference it to call the `operator bool()`. I don't think it's worth it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143104/new/

https://reviews.llvm.org/D143104