[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

[Sterling Augustine via Phabricator via lldb-commits]

saugustine added a comment.

I don't think this necessarily matters or is a reason to revert, but we are seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0.

The docs claim that versions past 3.0 are supported (except for some odd corner cases).

The failure is:

  Traceback (most recent call last):
    File "/build/work/37f17038e9cfbfbee7db556850bc7314bdb1/google3/runfiles/google3/third_party/llvm/llvm-project/lldb/test/API/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py", line 19, in test_address_breakpoints
      self.address_breakpoints()
    File "/build/work/37f17038e9cfbfbee7db556850bc7314bdb1/google3/runfiles/google3/third_party/llvm/llvm-project/lldb/test/API/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py", line 50, in address_breakpoints
      launch_info = lldb.SBLaunchInfo(None)
    File "/build/work/37f17038e9cfbfbee7db556850bc7314bdb1/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/google3/third_party/llvm/llvm-project/lldb/lib/python/site-packages/lldb/__init__.py", line 6239, in __init__
      this = _lldb.new_SBLaunchInfo(*args)
  ValueError: invalid null reference in method 'new_SBLaunchInfo', argument 1 of type 'lldb::SBLaunchInfo const &'
  Config=x86_64-/build/work/37f17038e9cfbfbee7db556850bc7314bdb1/google3/runfiles/google3/devtools/c/lldb/testing/clang

If I modify the line

  launch_info = lldb.SBLaunchInfo(None)

to

  launch_info = lldb.SBLaunchInfo("")

I get this error, which gives a clue to the fix:

  NotImplementedError: Wrong number or type of arguments for overloaded function 'new_SBLaunchInfo'.
    Possible C/C++ prototypes are:
      lldb::SBLaunchInfo::SBLaunchInfo(char const **)
      lldb::SBLaunchInfo::SBLaunchInfo(lldb::SBLaunchInfo const &)

So if I use a vector of strings to match the first overload, the error disappears and the tests pass:

  launch_info = lldb.SBLaunchInfo(["", ""])

Not sure the best way forward here. Either to abandon old versions of swig, or to clean up the launch command.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142926/new/

https://reviews.llvm.org/D142926