[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 16 08:04:29 PST 2023


DavidSpickett added a comment.

Note that this fixes https://github.com/llvm/llvm-project/issues/58769 in the commit message ("fixes #<the issue number>").

Also ping again! If you don't have the time to work on this in the near future, perhaps I can do the finishing touches and get it in (with you as co-author)? Would really like to see this issue fixed.



================
Comment at: lldb/source/Utility/DataExtractor.cpp:588
     uval64 >>= lsbcount;
+  } else {
+    uval64 <<= -lsbcount;
----------------
Remove the {} when using single line ifs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138197/new/

https://reviews.llvm.org/D138197



More information about the lldb-commits mailing list