[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 15 14:59:49 PST 2023
bulbazord added inline comments.
================
Comment at: lldb/tools/debugserver/source/debugserver.cpp:1342
DNBLogSetLogMask(log_flags);
}
----------------
jasonmolenda wrote:
> Should this be moved out of this `log_file != NULL` block so that the logging flags are set based on `-f` value? Otherwise looks good to me.
Good catch, that is indeed the case. I'll update this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144142/new/
https://reviews.llvm.org/D144142
More information about the lldb-commits
mailing list