[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

[Vasileios Porpodas via Phabricator via lldb-commits]

vporpo added inline comments.


================
Comment at: llvm/unittests/IR/ModuleTest.cpp:47-49
     // Sort the globals by name.
     EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare));
-    M.getGlobalList().sort(compare);
----------------
I removed this because it is testing whether ilist.sort() works, which is not Module-specific. This requires access to the full GlobalList for no real reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144027/new/

https://reviews.llvm.org/D144027