[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

Vasileios Porpodas via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 13 16:12:59 PST 2023


vporpo added inline comments.


================
Comment at: llvm/include/llvm/IR/Module.h:573
+  /// Inserts \p Alias into the alias list before \p Where and takes ownership.
+  void insertAlias(AliasListType::iterator Where, GlobalAlias *Alias) {
+    AliasList.insert(Where, Alias);
----------------
aeubanks wrote:
> this isn't used outside tests, remove?
Isn't it better to keep it for completeness? I don't feel strongly about it though, either way is fine with me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143958/new/

https://reviews.llvm.org/D143958



More information about the lldb-commits mailing list