[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

Pranav Kant via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 13 15:00:54 PST 2023


pranavk created this revision.
Herald added a project: All.
pranavk requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This reverts commit be7d7ca1101840fc8e19e0e48f9dc395da569d23 <https://reviews.llvm.org/rGbe7d7ca1101840fc8e19e0e48f9dc395da569d23>.

This commit was made to fix be7d7ca1101840fc8e19e0e48f9dc395da569d23 <https://reviews.llvm.org/rGbe7d7ca1101840fc8e19e0e48f9dc395da569d23>
which got reverted in 620b3d9ba3343d7bc5bab2340174a20952fcd00f <https://reviews.llvm.org/rG620b3d9ba3343d7bc5bab2340174a20952fcd00f>. We need
to revert this commit as well because types in log statements are 32 bit again.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143955

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@
   for (size_t i = 0; i < num_entries; ++i) {
     const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
     if (entry)
-      LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-                entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+      LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+                entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143955.497122.patch
Type: text/x-patch
Size: 711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230213/537f28f7/attachment-0001.bin>


More information about the lldb-commits mailing list